Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73568] rewrite the tests using RealJenkinsRule so test doesn't need to be skipped depending on Jenkins core version" #1625

Merged
merged 4 commits into from
Aug 5, 2024
Merged

[JENKINS-73568] rewrite the tests using RealJenkinsRule so test doesn't need to be skipped depending on Jenkins core version" #1625

merged 4 commits into from
Aug 5, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 5, 2024

  • Use RealJenkinsRule
  • Rewrite tests using RealJenkinsRule

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@olamy olamy requested a review from a team as a code owner August 5, 2024 01:10
@github-actions github-actions bot added dependencies Dependency related change tests Automated test addition or improvement labels Aug 5, 2024
olamy added 2 commits August 5, 2024 11:13
@olamy
Use RealJenkinsRule
cde5b99 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Rewrite tests using RealJenkinsRule
08c8557 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the JENKINS-73568-realjenkinsrule branch from 34e0458 to 08c8557 Compare August 5, 2024 01:16
olamy added 2 commits August 5, 2024 11:19
@olamy
exclusion not needed
5037b62 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
add comments about the exclusion
aff1529 
Signed-off-by: Olivier Lamy <olamy@apache.org>
MarkEWaite
MarkEWaite approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks very much!

@MarkEWaite MarkEWaite merged commit f87418a into master Aug 5, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the JENKINS-73568-realjenkinsrule branch August 5, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
dependencies Dependency related change tests Automated test addition or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamy @MarkEWaite